pipeline: Init pipeline api #478

Xieql · 2023-11-24T03:27:51Z

What type of PR is this?

/kind api-change

/kind design

/kind feature

What this PR does / why we need it:

pipeline api of #476

netlify · 2023-11-24T03:27:56Z

✅ Deploy Preview for kurator-dev ready!

Name	Link
🔨 Latest commit	`24c8db2`
🔍 Latest deploy log	https://app.netlify.com/sites/kurator-dev/deploys/6572cf3fa3b6fe000818bef6
😎 Deploy Preview	https://deploy-preview-478--kurator-dev.netlify.app/references/pipeline_v1alpha1_types
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kurator-bot · 2023-11-24T03:27:57Z

@Xieql: The label(s) kind/design cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind api-change

/kind design

/kind feature

What this PR does / why we need it:

pipeline api of #476

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Xieql <[email protected]>

Xieql · 2023-12-07T03:34:13Z

@hzxuzhonghu PTAL

hzxuzhonghu · 2023-12-07T06:28:15Z

pkg/apis/pipeline/v1alpha1/type.go

+
+	// Retries represents how many times this task should be retried in case of task failure.
+	// +optional
+	Retries *int `json:"retries,omitempty"`


Document the defaut retries, if no retry by default, this can be int

yes, default is zero.

hzxuzhonghu · 2023-12-07T06:33:18Z

pkg/apis/pipeline/v1alpha1/type.go

+	// TaskRef is a reference to a predefined task template.
+	// Users should provide a TaskRef name from a predefined library.
+	// +optional
+	TaskRef *TaskRef `json:"taskRef,omitempty"`


Seems taskRef is not good, it is inner task spec. How about calling TaskTemplate *TaskTemplate

hzxuzhonghu · 2023-12-07T06:35:17Z

pkg/apis/pipeline/v1alpha1/type.go

+	// Users don't need to configure additional repository information for this task, except for authentication details for private repositories.
+	// This Predefined Task is origin from https://github.com/tektoncd/catalog/tree/main/task/git-clone/0.9
+	// Here are the params that user can config:
+	// - git-secret-name: the secret name of git basic auth, Kurator use this git credential to clone private repo.


how should user provide such secret and with what format

we can add more format details, and tell user how to create it with following Pipeline doc in kurator site

hzxuzhonghu · 2023-12-07T06:38:32Z

pkg/apis/pipeline/v1alpha1/type.go

+type TaskRef struct {
+	// TaskType is used to specify the type of the predefined task.
+	// This is a required field and determines which task template will be used.
+	TaskType PredefinedTask `json:"taskType"`


I see it as the intree task template Name

yes, it affects which task template will be executed actually

I mean rename to Name

hzxuzhonghu · 2023-12-07T06:40:07Z

pkg/apis/pipeline/v1alpha1/type.go

+	// Image specifies the Docker image name.
+	// More info: https://kubernetes.io/docs/concepts/containers/images
+	// +optional
+	Image string `json:"image,omitempty" protobuf:"bytes,2,opt,name=image"`


remove all the protobuf tag

yes，we don't need it

Signed-off-by: Xieql <[email protected]>

Xieql · 2023-12-07T08:34:32Z

@hzxuzhonghu PTAL

hzxuzhonghu · 2023-12-07T08:41:10Z

pkg/apis/pipeline/v1alpha1/type.go

+	//   https://kurator.dev/docs/fleet-manager/pipeline/
+	//   .gitconfig example:
+	//   |   [credential "https://<hostname>"]
+	//   |       helper = store
+	//   .git-credentials example:
+	//   |   https://<user>:<pass>@<hostname>


Your comments is not user provided format
This is the right auth secret format
https://tekton.dev/docs/pipelines/auth/#configuring-authentication-for-git

Signed-off-by: Xieql <[email protected]>

Xieql · 2023-12-08T02:13:39Z

/label tide/merge-method-squash

Xieql · 2023-12-08T02:47:15Z

@hzxuzhonghu PTAL

hzxuzhonghu · 2023-12-08T02:59:25Z

last comment #478 (comment)

Signed-off-by: Xieql <[email protected]>

Xieql · 2023-12-08T08:12:08Z

For all task, the workspace is automatically and exclusively assigned to the workspace of the pipeline in which this task is located.

so user don't need to set this value

Xieql · 2023-12-08T08:17:26Z

@hzxuzhonghu PTAL

hzxuzhonghu · 2023-12-08T08:33:15Z

/lgtm
/approve

kurator-bot · 2023-12-08T08:33:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kurator-bot added the kind/api-change label Nov 24, 2023

kurator-bot requested review from hzxuzhonghu and zirain November 24, 2023 03:27

kurator-bot added the kind/feature label Nov 24, 2023

kurator-bot added the size/XXL label Nov 24, 2023

Xieql force-pushed the init-pipeline-api branch 4 times, most recently from f61fa72 to 906c3fd Compare November 24, 2023 07:38

Xieql mentioned this pull request Nov 24, 2023

[FR]Provide a CI/CD Solution for Kurator #435

Closed

2 tasks

Xieql marked this pull request as draft November 24, 2023 09:27

kurator-bot added the do-not-merge/work-in-progress label Nov 24, 2023

Xieql force-pushed the init-pipeline-api branch from 906c3fd to fc9c562 Compare November 25, 2023 01:17

Xieql added 3 commits December 7, 2023 10:54

pipeline: add pipeline sync api

4ee0b14

Signed-off-by: Xieql <[email protected]>

pipeline: update api gen script

c004ce2

Signed-off-by: Xieql <[email protected]>

pipeline: make gen api

0dc78fe

Signed-off-by: Xieql <[email protected]>

Xieql force-pushed the init-pipeline-api branch from fc9c562 to 0dc78fe Compare December 7, 2023 03:11

Xieql marked this pull request as ready for review December 7, 2023 03:12

kurator-bot removed the do-not-merge/work-in-progress label Dec 7, 2023

Xieql mentioned this pull request Dec 7, 2023

[FR] The realization of pipeline. #493

Open

24 tasks

hzxuzhonghu reviewed Dec 7, 2023

View reviewed changes

Xieql added 2 commits December 7, 2023 16:17

pipeline: update api

fbb15b2

Signed-off-by: Xieql <[email protected]>

pipeline: update make gen

996ed6c

Signed-off-by: Xieql <[email protected]>

hzxuzhonghu reviewed Dec 7, 2023

View reviewed changes

update

4ff17bc

Signed-off-by: Xieql <[email protected]>

kurator-bot added the tide/merge-method-squash label Dec 8, 2023

update

910668f

Signed-off-by: Xieql <[email protected]>

Xieql marked this pull request as draft December 8, 2023 07:31

kurator-bot added the do-not-merge/work-in-progress label Dec 8, 2023

update

24c8db2

Signed-off-by: Xieql <[email protected]>

Xieql marked this pull request as ready for review December 8, 2023 08:20

kurator-bot removed the do-not-merge/work-in-progress label Dec 8, 2023

kurator-bot requested review from hzxuzhonghu and kevin-wangzefeng December 8, 2023 08:20

kurator-bot assigned hzxuzhonghu Dec 8, 2023

kurator-bot added the lgtm label Dec 8, 2023

kurator-bot added the approved label Dec 8, 2023

kurator-bot merged commit bee332e into kurator-dev:main Dec 8, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pipeline: Init pipeline api #478

pipeline: Init pipeline api #478

Xieql commented Nov 24, 2023

netlify bot commented Nov 24, 2023 •

edited

Loading

kurator-bot commented Nov 24, 2023

Xieql commented Dec 7, 2023

hzxuzhonghu Dec 7, 2023

Xieql Dec 7, 2023

hzxuzhonghu Dec 7, 2023

Xieql Dec 7, 2023

hzxuzhonghu Dec 7, 2023

Xieql Dec 7, 2023 •

edited

Loading

hzxuzhonghu Dec 7, 2023

Xieql Dec 7, 2023

hzxuzhonghu Dec 7, 2023

hzxuzhonghu Dec 7, 2023

Xieql Dec 7, 2023

Xieql commented Dec 7, 2023

hzxuzhonghu Dec 7, 2023 •

edited

Loading

Xieql Dec 8, 2023

Xieql commented Dec 8, 2023

Xieql commented Dec 8, 2023

hzxuzhonghu commented Dec 8, 2023

Xieql commented Dec 8, 2023

Xieql commented Dec 8, 2023

hzxuzhonghu commented Dec 8, 2023

kurator-bot commented Dec 8, 2023

pipeline: Init pipeline api #478

pipeline: Init pipeline api #478

Conversation

Xieql commented Nov 24, 2023

netlify bot commented Nov 24, 2023 • edited Loading

✅ Deploy Preview for kurator-dev ready!

kurator-bot commented Nov 24, 2023

Xieql commented Dec 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xieql Dec 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xieql commented Dec 7, 2023

hzxuzhonghu Dec 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xieql commented Dec 8, 2023

Xieql commented Dec 8, 2023

hzxuzhonghu commented Dec 8, 2023

Xieql commented Dec 8, 2023

Xieql commented Dec 8, 2023

hzxuzhonghu commented Dec 8, 2023

kurator-bot commented Dec 8, 2023

netlify bot commented Nov 24, 2023 •

edited

Loading

Xieql Dec 7, 2023 •

edited

Loading

hzxuzhonghu Dec 7, 2023 •

edited

Loading